Skip to content

fix: Avoid ClassCastException and reduce copy/pasta 🍝 in FunctionTool #489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 24, 2025
Merged

fix: Avoid ClassCastException and reduce copy/pasta 🍝 in FunctionTool #489

merged 1 commit into from
Oct 24, 2025
+32 −62

Conversation

@vorburger
Copy link
Member

Prompted by #487 (comment).

@vorburger vorburger requested a review from Poggecci October 7, 2025 20:08
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @vorburger, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the FunctionTool class to improve code organization, reduce duplication, and enhance robustness in argument processing. By extracting common argument building and type resolution logic into dedicated helper methods, the PR makes the call and callLive methods cleaner and more resilient to various input scenarios, addressing potential runtime exceptions related to type casting and null references.

Highlights

  • Refactoring for Reusability: The logic for building method arguments, previously duplicated in call and callLive methods, has been extracted into a new private helper method named buildArguments. This significantly reduces code duplication and improves maintainability.
  • Improved Type Handling: A new private static helper method, getTypeClass, was introduced to correctly resolve the Class type from a java.lang.reflect.Type object, specifically handling both simple Class types and ParameterizedTypes. This centralizes type resolution logic and prevents potential ClassCastExceptions.
  • Enhanced Robustness: Added a null check for invocationContext within the buildArguments method when handling inputStream parameters, preventing potential NullPointerExceptions in scenarios where invocationContext might not be provided.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

@vorburger vorburger mentioned this pull request Oct 7, 2025
Draft
gemini-code-assist[bot]
gemini-code-assist bot reviewed Oct 7, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request does a great job of refactoring the FunctionTool class to eliminate duplicated code by introducing a buildArguments method. This significantly improves the maintainability and clarity of the call and callLive methods. The change also correctly addresses a potential ClassCastException by introducing the getTypeClass helper, making type handling for list parameters more robust. Overall, this is a solid improvement to the codebase. I have one minor suggestion to further improve readability.

@Poggecci Poggecci self-requested a review October 24, 2025 17:16
@copybara-service copybara-service bot merged commit cfdb958 into google:main Oct 24, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Poggecci Poggecci Poggecci approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ready to pull

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vorburger @Poggecci